Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/23063 )
Change subject: [thrift] Suppress Thrift warnings using -nowarn option ...................................................................... Patch Set 3: -Code-Review (1 comment) Sorry just one more commit message formatting nit, else LGTM! http://gerrit.cloudera.org:8080/#/c/23063/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23063/3//COMMIT_MSG@17 PS3, Line 17: from the Apache Hive project and should not be modified for compatibility reasons. nit: commit message body lines should be 72 chars max. for the error message I think for readability we can omit the rule. But for other sentences please keep to formatting guideline. -- To view, visit http://gerrit.cloudera.org:8080/23063 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifdb8b650f9b8ed1cdea9dd0cf1a80ef264ccc7d7 Gerrit-Change-Number: 23063 Gerrit-PatchSet: 3 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Wed, 25 Jun 2025 10:27:18 +0000 Gerrit-HasComments: Yes
