Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23064 )
Change subject: [tablet] avoid -Wpsabi warning in ComputeLowerAndUpperBound on Rocky ARM ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Looks good to me. Just one nit. http://gerrit.cloudera.org:8080/#/c/23064/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23064/3//COMMIT_MSG@31 PS3, Line 31: but the effect is purely internal and does not : affect correctness This can lead to confusion. You can shorten this to: "that does not affect correctness." -- To view, visit http://gerrit.cloudera.org:8080/23064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab4db585a8eaf152f1fa2884e72e38a4e7c5efa1 Gerrit-Change-Number: 23064 Gerrit-PatchSet: 3 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Wed, 25 Jun 2025 08:20:11 +0000 Gerrit-HasComments: Yes
