KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/23064 )
Change subject: [Rocky] suppress -Wpsabi warning with targeted GCC version check ...................................................................... Patch Set 6: Thank you for the detailed review and clarification. You're absolutely right—ComputeLowerAndUpperBound() is internal and not part of Kudu's ABI, and with all intermediate libraries being statically linked in release builds, there's indeed no risk of ABI incompatibility from mixing compiler versions. Based on your suggestion, I’ve updated the patch to suppress the -Wpsabi warning using a targeted #pragma GCC diagnostic ignored "-Wpsabi" around the function. To avoid unnecessarily applying the suppression to unrelated compilers like Clang or GCC versions that don’t emit the warning, I’ve wrapped the pragma in a conditional that checks for GCC ≥ 10.1. This keeps the function signature unchanged and avoids introducing new types solely to work around a harmless warning, while keeping the build clean on affected platforms. -- To view, visit http://gerrit.cloudera.org:8080/23064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab4db585a8eaf152f1fa2884e72e38a4e7c5efa1 Gerrit-Change-Number: 23064 Gerrit-PatchSet: 6 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Thu, 26 Jun 2025 03:47:14 +0000 Gerrit-HasComments: No
