KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/23063 )
Change subject: [thrift] Add support for extra Thrift options to THRIFT_GENERATE_CPP() ...................................................................... Patch Set 5: (1 comment) Thanks for your reviews. http://gerrit.cloudera.org:8080/#/c/23063/4/cmake_modules/FindThrift.cmake File cmake_modules/FindThrift.cmake: http://gerrit.cloudera.org:8080/#/c/23063/4/cmake_modules/FindThrift.cmake@127 PS4, Line 127: --gen cpp:moveable_types > I don't think doing this in a blanket-style manner like you did here is a g Done -- To view, visit http://gerrit.cloudera.org:8080/23063 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifdb8b650f9b8ed1cdea9dd0cf1a80ef264ccc7d7 Gerrit-Change-Number: 23063 Gerrit-PatchSet: 5 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Thu, 26 Jun 2025 02:29:53 +0000 Gerrit-HasComments: Yes
