Marton Greber has posted comments on this change. (
http://gerrit.cloudera.org:8080/23063 )
Change subject: [thrift] Silence Thrift compiler warnings by redirecting
......................................................................
Patch Set 2:
Thanks for the quick update!
Suppressing all the stdout and stderr is a harsh measure in my opinion for just
a single warning.
I did take a look at thrift CLI and there is an option:
-nowarn
that suppresses all warnings. [1]
I would say that this would be an acceptable solution if we want to clean up
our build log.
Let me know what do you think!
[1] this is what i've tried out locally:
ARGS
-nowarn
--gen cpp:moveable_types
--recurse
--out ${ARG_BINARY_ROOT}
-I ${ARG_SOURCE_ROOT}
# Used to find built-in .thrift files (e.g. fb303.thrift)
-I ${THIRDPARTY_INSTALL_CURRENT_DIR}
${EXTRA_THRIFT_PATH_ARGS} ${ABS_FIL}
--
To view, visit http://gerrit.cloudera.org:8080/23063
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifdb8b650f9b8ed1cdea9dd0cf1a80ef264ccc7d7
Gerrit-Change-Number: 23063
Gerrit-PatchSet: 2
Gerrit-Owner: KeDeng <[email protected]>
Gerrit-Reviewer: KeDeng <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Comment-Date: Tue, 24 Jun 2025 10:26:44 +0000
Gerrit-HasComments: No
