Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22819 )
Change subject: [util] introduce ChunkedBitmapIterator ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/22819/4/src/kudu/util/bitmap.h File src/kudu/util/bitmap.h: http://gerrit.cloudera.org:8080/#/c/22819/4/src/kudu/util/bitmap.h@147 PS4, Line 147: virtual size_t Next(bool* value) = 0; Are you sure changing this from an inline to a virtual function won't have any performance impact? -- To view, visit http://gerrit.cloudera.org:8080/22819 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I143e3caa7cd8d48be8034c630f79562c2fc1282a Gerrit-Change-Number: 22819 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Tue, 08 Jul 2025 07:39:48 +0000 Gerrit-HasComments: Yes
