Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22819 )
Change subject: [util] introduce ChunkedBitmapIterator ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/22819/5/src/kudu/util/bitmap-test.cc File src/kudu/util/bitmap-test.cc: http://gerrit.cloudera.org:8080/#/c/22819/5/src/kudu/util/bitmap-test.cc@852 PS5, Line 852: nothig > nit: fix typo and elsewhere also I re-worked the code that used to use this ChunkedBitmapIterator class, and now ChunkedBitmapIterator is no longer needed. I'm about to abandon this patch, so I'm not addressing these nits. Thank you for the review! http://gerrit.cloudera.org:8080/#/c/22819/5/src/kudu/util/bitmap.h File src/kudu/util/bitmap.h: http://gerrit.cloudera.org:8080/#/c/22819/5/src/kudu/util/bitmap.h@209 PS5, Line 209: DCHECK_EQ > Why is DCHECK_EQ used here instead of CHECK_EQ? DCHECK_EQ() is enough to protect against programming errors when the variation comes from the code, not from the data itself. The size of the containers in both parameters are constructed and controlled by the code. If there is a programming error somewhere, these DCHECK will catch the error because all the pre-commit tests are run against DEBUG bits as well along with RELEASE, ASAN, TSAN bits. Using CHECK() does make sense only when there is no other way to handle a condition that otherwise could lead to inconsistency if just returning error Status and exiting from the control flow. -- To view, visit http://gerrit.cloudera.org:8080/22819 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I143e3caa7cd8d48be8034c630f79562c2fc1282a Gerrit-Change-Number: 22819 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Tue, 26 Aug 2025 15:02:34 +0000 Gerrit-HasComments: Yes
