Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/21723 )
Change subject: Add Prometheus HTTP service discovery ...................................................................... Patch Set 6: Code-Review+1 (5 comments) http://gerrit.cloudera.org:8080/#/c/21723/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21723/3//COMMIT_MSG@14 PS3, Line 14: servers. This returns the Kudu Master and TServers, according to the > Yes you are correct, with --webserver_require_spnego Prometheus wont work. Having the ability to set auth per endpoint would be a great addition! For now the ability to turn off spnego for Prometheus would be okay, however if customers run any sort of security scans against the webserver, it will definitely trigger an alarm for unsecure endpoint. http://gerrit.cloudera.org:8080/#/c/21723/3//COMMIT_MSG@58 PS3, Line 58: Kudu > Good question! Ack http://gerrit.cloudera.org:8080/#/c/21723/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21723/6//COMMIT_MSG@91 PS6, Line 91: added basic nit: added a basic http://gerrit.cloudera.org:8080/#/c/21723/6/src/kudu/master/master-test.cc File src/kudu/master/master-test.cc: http://gerrit.cloudera.org:8080/#/c/21723/6/src/kudu/master/master-test.cc@3985 PS6, Line 3985: mini_master_->Shutdown(); is the Shutdown() necessary before a Restart()? http://gerrit.cloudera.org:8080/#/c/21723/6/src/kudu/master/master_path_handlers.cc File src/kudu/master/master_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/21723/6/src/kudu/master/master_path_handlers.cc@948 PS6, Line 948: skipping maybe "excluding" would be better? -- To view, visit http://gerrit.cloudera.org:8080/21723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I931aa72a7567c0dde43d7b7ed53a2dd0fa8bc1fe Gerrit-Change-Number: 21723 Gerrit-PatchSet: 6 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Mon, 14 Jul 2025 07:07:21 +0000 Gerrit-HasComments: Yes
