Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21723 )
Change subject: Add Prometheus HTTP service discovery ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/21723/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21723/3//COMMIT_MSG@14 PS3, Line 14: servers. This returns the Kudu Master and TServers grouped, according > Having the ability to set auth per endpoint would be a great addition! For As a second thought if customers are running Knox I think they can do some proxying. Good point again to investigate and include it in the blogpost. Thanks! http://gerrit.cloudera.org:8080/#/c/21723/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21723/6//COMMIT_MSG@91 PS6, Line 91: > nit: added a basic Done http://gerrit.cloudera.org:8080/#/c/21723/6/src/kudu/master/master-test.cc File src/kudu/master/master-test.cc: http://gerrit.cloudera.org:8080/#/c/21723/6/src/kudu/master/master-test.cc@3985 PS6, Line 3985: > is the Shutdown() necessary before a Restart()? I was using this as other tests in this test file did the same. Did try without shutdown but then there is some issue. http://gerrit.cloudera.org:8080/#/c/21723/6/src/kudu/master/master-test.cc@3991 PS6, Line 3991: > Consider adding a "using" declaration for this. Done http://gerrit.cloudera.org:8080/#/c/21723/6/src/kudu/master/master_path_handlers.cc File src/kudu/master/master_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/21723/6/src/kudu/master/master_path_handlers.cc@948 PS6, Line 948: > maybe "excluding" would be better? Done -- To view, visit http://gerrit.cloudera.org:8080/21723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I931aa72a7567c0dde43d7b7ed53a2dd0fa8bc1fe Gerrit-Change-Number: 21723 Gerrit-PatchSet: 3 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Mon, 14 Jul 2025 13:53:38 +0000 Gerrit-HasComments: Yes
