Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22984 )
Change subject: [net] KUDU-1457 [1/n] Add support for IPv6 ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/22984/6/src/kudu/util/net/sockaddr.h File src/kudu/util/net/sockaddr.h: http://gerrit.cloudera.org:8080/#/c/22984/6/src/kudu/util/net/sockaddr.h@87 PS6, Line 87: A.B.C.D:port nit: Update comment? http://gerrit.cloudera.org:8080/#/c/22984/6/src/kudu/util/net/sockaddr.cc File src/kudu/util/net/sockaddr.cc: http://gerrit.cloudera.org:8080/#/c/22984/6/src/kudu/util/net/sockaddr.cc@138 PS6, Line 138: static_assert nit: Do we need the corresponding static asserts in case of IPv6 too? -- To view, visit http://gerrit.cloudera.org:8080/22984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22c773ffb2ff44b9cd765b546d6724ec5543586f Gerrit-Change-Number: 22984 Gerrit-PatchSet: 6 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 23 Jul 2025 00:26:22 +0000 Gerrit-HasComments: Yes
