Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/22984 )
Change subject: KUDU-1457 [1/n] add IPv6 support to net utils ...................................................................... Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/22984/8/src/kudu/util/net/net_util.cc File src/kudu/util/net/net_util.cc: http://gerrit.cloudera.org:8080/#/c/22984/8/src/kudu/util/net/net_util.cc@193 PS8, Line 193: constexpr is this really constexpr? http://gerrit.cloudera.org:8080/#/c/22984/8/src/kudu/util/net/net_util.cc@432 PS8, Line 432: host_.find(host_, ':') The code calls host_.find(host_, ':'). Did we mean to search for a colon rather than the whole host_ string starting at position ':'? http://gerrit.cloudera.org:8080/#/c/22984/8/src/kudu/util/net/net_util.cc@450 PS8, Line 450: return IN6_IS_ADDR_LOOPBACK(&addr); IN6_IS_ADDR_LOOPBACK(&addr) expects const in6_addr*, but we pass a uint128_t*. Should we convert first? http://gerrit.cloudera.org:8080/#/c/22984/8/src/kudu/util/net/net_util.cc@463 PS8, Line 463: str Should we handle the case where inet_ntop() fails and str remains uninitialized? http://gerrit.cloudera.org:8080/#/c/22984/8/src/kudu/util/net/sockaddr.h File src/kudu/util/net/sockaddr.h: http://gerrit.cloudera.org:8080/#/c/22984/8/src/kudu/util/net/sockaddr.h@112 PS8, Line 112: // Set the IP port for this address. : // REQUIRES: is an IP address. : void set_port(in_port_t port); : : // Get the IP port for this address. : // REQUIRES: is an IP address. : uint16_t port() const; Should both methods use the same type for consistency? -- To view, visit http://gerrit.cloudera.org:8080/22984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22c773ffb2ff44b9cd765b546d6724ec5543586f Gerrit-Change-Number: 22984 Gerrit-PatchSet: 8 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Mon, 28 Jul 2025 12:21:26 +0000 Gerrit-HasComments: Yes
