Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23295 )
Change subject: Fix compilation if using OpenSSL < 1.1.1 ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/23295/2//COMMIT_MSG Commit Message: PS2: One missing part is checking against the set min TLS version and available version. It might be something similar to CheckMaxSupportedTlsVersion() in tls_context.cc, but applicable to the webserver's specific flag --webserver_tls_min_protocol http://gerrit.cloudera.org:8080/#/c/23295/2/thirdparty/patches/squeasel-tls-openssl10x.patch File thirdparty/patches/squeasel-tls-openssl10x.patch: http://gerrit.cloudera.org:8080/#/c/23295/2/thirdparty/patches/squeasel-tls-openssl10x.patch@18 PS2, Line 18: defined(SSL_CTX_set_ciphersuites) I don't think SSL_CTX_set_ciphersuites is a macro, at least in OpenSSL 1.1.1, so this isn't going to work. Essentially, this always evaluates to false, even in OpenSSL 1.1.1 and newer. -- To view, visit http://gerrit.cloudera.org:8080/23295 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef Gerrit-Change-Number: 23295 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 14 Aug 2025 13:18:57 +0000 Gerrit-HasComments: Yes
