Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23295 )
Change subject: Fix compilation if using OpenSSL < 1.1.1 ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/23295/3/src/kudu/server/webserver_options.cc File src/kudu/server/webserver_options.cc: http://gerrit.cloudera.org:8080/#/c/23295/3/src/kudu/server/webserver_options.cc@179 PS3, Line 179: LOG(ERROR) << "TLSv1.3 requested, but available OpenSSL version " : "is too old (need >= 1.1.1)"; With this, does it make sense to update the description for the webserver_tls_min_protocol flag as well to exclude TLSv1.3 from the list of acceptable settings if compiling with OpenSSL of versions earlier than 1.1.1? http://gerrit.cloudera.org:8080/#/c/23295/3/thirdparty/download-thirdparty.sh File thirdparty/download-thirdparty.sh: http://gerrit.cloudera.org:8080/#/c/23295/3/thirdparty/download-thirdparty.sh@281 PS3, Line 281: SQUEASEL_PATCHLEVEL=3 > nit: Do you think patch level should be 4 now? +1 -- To view, visit http://gerrit.cloudera.org:8080/23295 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef Gerrit-Change-Number: 23295 Gerrit-PatchSet: 3 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 21 Aug 2025 19:35:30 +0000 Gerrit-HasComments: Yes
