Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/22984 )
Change subject: KUDU-1457 [1/n] add IPv6 support to net utils ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/22984/12/src/kudu/util/net/net_util.cc File src/kudu/util/net/net_util.cc: http://gerrit.cloudera.org:8080/#/c/22984/12/src/kudu/util/net/net_util.cc@347 PS12, Line 347: DCHECK(AF_INET == ai->ai_family || AF_INET6 == ai->ai_family); > this used to be a CHECK and now it's DCHECK. Is it safe? Shouldn't it crash I don't think this CHECK was there to catch any incorrect family protocol. I believe the primary reason behind adding CHECK_EQ was probably to ensure that it is just IPv4 address family type sockets and no IPv6 (with no support for IPv6 addresses at the time). With IPv6 support, this would obviously become either-or situation. I am unaware of any other scenario when this would become anything other than IPv4 and IPv6. I would be surprised if name resolution here is being used for non-IP type hosts. If you think it is possible to be in such scenario, I don't mind adding back CHECK_EQ. -- To view, visit http://gerrit.cloudera.org:8080/22984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22c773ffb2ff44b9cd765b546d6724ec5543586f Gerrit-Change-Number: 22984 Gerrit-PatchSet: 12 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Fri, 22 Aug 2025 10:59:11 +0000 Gerrit-HasComments: Yes
