Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22984 )
Change subject: KUDU-1457 [1/n] add IPv6 support to net utils ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/22984/1/src/kudu/util/net/sockaddr.cc File src/kudu/util/net/sockaddr.cc: http://gerrit.cloudera.org:8080/#/c/22984/1/src/kudu/util/net/sockaddr.cc@225 PS1, Line 225: set_length(sizeof(addr)); : memcpy(&storage_, &addr, len_); > Actually, this code doesn't need to change as long as we are setting length Indeed, the sin6_flowinfo come before the sin6_addr field in the sockaddr_in6 structure. Zeroing out sin6_flowinfo and sin6_scope_id in ParseFromNumericHostPort() makes sense, but there are other places where Sockaddr object in constructed or assigned using sockaddr_in6 coming from outside. That needs extra care, because if these fields aren't zeroed out in the incoming sockaddr_in6 structure, Sockaddr::BytewiseCompare() and Sockaddr::HashCode() isn't going to work as expected. -- To view, visit http://gerrit.cloudera.org:8080/22984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22c773ffb2ff44b9cd765b546d6724ec5543586f Gerrit-Change-Number: 22984 Gerrit-PatchSet: 1 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Fri, 22 Aug 2025 21:13:31 +0000 Gerrit-HasComments: Yes
