Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/23424 )
Change subject: Add equals() and hashCode() methods to PartialRow and PartitionSchema ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/23424/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java: http://gerrit.cloudera.org:8080/#/c/23424/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java@634 PS2, Line 634: @Test : public void testEquals() { > nit: at the very end could you also add a 'happy' case where we assert true Done http://gerrit.cloudera.org:8080/#/c/23424/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java@659 PS2, Line 659: assertTrue(row1.equals(row1)); : > nit: here can you add some negative cases, where we are not expecting hashe Done http://gerrit.cloudera.org:8080/#/c/23424/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestPartitionSchemaClasses.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestPartitionSchemaClasses.java: http://gerrit.cloudera.org:8080/#/c/23424/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestPartitionSchemaClasses.java@40 PS2, Line 40: public void testHashBucketSchemaEquals() { : PartitionSchema.HashBucketSchema schema1 = new PartitionSchema.HashBucketSchema( : Arrays.asList(1, 2), 16, 42); : PartitionSchema.HashBucketSchema schema2 = new PartitionSchema.HashBucketSchema( : Arrays.asList(1, 2), 16, 42); : : assertEquals(schema1, schema2); : assertEquals(schema1.hashCode(), schema2.hashCode()); : > nit: can you please add some negative cases as well? Done -- To view, visit http://gerrit.cloudera.org:8080/23424 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea7d547397c37506c7d0baf4f66aa6b34a99f10e Gerrit-Change-Number: 23424 Gerrit-PatchSet: 3 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Thu, 18 Sep 2025 12:16:27 +0000 Gerrit-HasComments: Yes
