Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23424 )
Change subject: Add equals() and hashCode() methods to PartialRow and PartitionSchema ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Overall looks good to me! Just a nitpick. http://gerrit.cloudera.org:8080/#/c/23424/3/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java File java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java: http://gerrit.cloudera.org:8080/#/c/23424/3/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@1972 PS3, Line 1972: return true nit: If we know what is required for two objects to be equal, we could just check those conditions (I am guessing number of such conditions would be less) and return true. Return false for rest of it. That way, the logic becomes simpler in terms of readability. -- To view, visit http://gerrit.cloudera.org:8080/23424 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea7d547397c37506c7d0baf4f66aa6b34a99f10e Gerrit-Change-Number: 23424 Gerrit-PatchSet: 3 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Fri, 19 Sep 2025 10:37:17 +0000 Gerrit-HasComments: Yes
