Alexey Serbin has uploaded this change for review. (
http://gerrit.cloudera.org:8080/23447
Change subject: [thirdparty] upgrade cpplint up to 1.6.1 release
......................................................................
[thirdparty] upgrade cpplint up to 1.6.1 release
The prior version of the cpplint tool from the google-styleguide project
[1] was from 2016 and it wasn't aware of the C++17 constructs such as
'if constexpr (...) {...}', so it would error out on such a code with
messages like below:
If/else bodies with multiple statements require braces [readability/braces]
At the time of writing, the latest released version of the cpplint tool
is 2.0.2 [2]. However, version 2.0.0 dropped Python2 and Python3.7
support, and it seems the 2.0.x release line is not quite stable yet.
The safest bet at this time is 1.6.1 which includes the fix for the
issue [3] and is the latest release in the 1.x line. It was released
about 3 years ago in August 2022.
Since the cpplint tool has been moved into a separate repo [4] and
it isn't a part of the google-styleguide project repo [1] anymore,
I renamed corresponding entities for this Kudu's 3rd-party component
and updated the scripts accordingly:
GSG --> CPPLINT
[1] https://github.com/google/styleguide
[2] https://github.com/cpplint/cpplint/releases/tag/2.0.2
[3] https://github.com/cpplint/cpplint/commit/6e3e178b0
[4] https://github.com/cpplint/cpplint
Change-Id: I390dad51e8e0a57e5823ad789f7f8b0029e5bdb4
---
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/patches/google-styleguide-cpplint.patch
M thirdparty/vars.sh
5 files changed, 24 insertions(+), 58 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/23447/1
--
To view, visit http://gerrit.cloudera.org:8080/23447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I390dad51e8e0a57e5823ad789f7f8b0029e5bdb4
Gerrit-Change-Number: 23447
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <[email protected]>
