Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/23447 )
Change subject: [thirdparty] upgrade cpplint up to 1.6.1 release ...................................................................... Patch Set 3: Code-Review+1 (2 comments) Overall looks good, I just have one question. http://gerrit.cloudera.org:8080/#/c/23447/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23447/3//COMMIT_MSG@18 PS3, Line 18: 2.0.x release line is not quite stable yet Do you have specific evidence of instability, or is this more of a conservative approach? http://gerrit.cloudera.org:8080/#/c/23447/3/thirdparty/vars.sh File thirdparty/vars.sh: http://gerrit.cloudera.org:8080/#/c/23447/3/thirdparty/vars.sh@124 PS3, Line 124: git co 1.6.1 nit: For better clarity and copy-pasteable documentation, consider using the full command git checkout 1.6.1 instead of the alias git co 1.6.1, since not all users may have this alias configured. -- To view, visit http://gerrit.cloudera.org:8080/23447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I390dad51e8e0a57e5823ad789f7f8b0029e5bdb4 Gerrit-Change-Number: 23447 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Mon, 22 Sep 2025 09:30:11 +0000 Gerrit-HasComments: Yes
