Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23461 )
Change subject: KUDU-1261 introduce serdes utilities for scalar arrays ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/23461/2/src/kudu/common/array_cell_view.h File src/kudu/common/array_cell_view.h: http://gerrit.cloudera.org:8080/#/c/23461/2/src/kudu/common/array_cell_view.h@38 PS2, Line 38: KuduToScalarArrayType missing BOOL DataType? http://gerrit.cloudera.org:8080/#/c/23461/2/src/kudu/common/array_cell_view.h@192 PS2, Line 192: size_t Should be bool? http://gerrit.cloudera.org:8080/#/c/23461/2/src/kudu/common/array_cell_view.h@270 PS2, Line 270: arrray1d nit: array1d http://gerrit.cloudera.org:8080/#/c/23461/2/src/kudu/common/array_type_serdes.h File src/kudu/common/array_type_serdes.h: http://gerrit.cloudera.org:8080/#/c/23461/2/src/kudu/common/array_type_serdes.h@179 PS2, Line 179: switch What about FLOAT/DOUBLE? http://gerrit.cloudera.org:8080/#/c/23461/2/src/kudu/common/array_type_serdes.h@254 PS2, Line 254: DATE Should this map into Int32 as above? http://gerrit.cloudera.org:8080/#/c/23461/2/src/kudu/common/types.h File src/kudu/common/types.h: http://gerrit.cloudera.org:8080/#/c/23461/2/src/kudu/common/types.h@932 PS2, Line 932: aray nit: array -- To view, visit http://gerrit.cloudera.org:8080/23461 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7384580ea9eaa37e6f49dbc9746d9994c3f7ade6 Gerrit-Change-Number: 23461 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Sat, 27 Sep 2025 03:17:34 +0000 Gerrit-HasComments: Yes
