Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23461 )
Change subject: KUDU-1261 introduce serdes utilities for scalar arrays ...................................................................... KUDU-1261 introduce serdes utilities for scalar arrays This changelist introduces serialization utility functions Serialize() and SerializeIntoArena() for one-dimensional arrays (common/array_type_serdes.h). Accordingly, for accessing the data in the serialized buffer, the ArrayCellMetadataView class is introduced (common/array_cell_view.h). This changelist also adds implementation of ArrayTypeTraits' methods: * void AppendDebugStringForValue(const void* val, std::string* str) * int Compare(const void* lhs, const void* rhs) * bool AreConsecutive(const void* a, const void* b) Corresponding unit test are included: while the current coverage isn't exhaustive, it seems to be good enough as a starting point, and more tests can be added later on, if necessary. Change-Id: I7384580ea9eaa37e6f49dbc9746d9994c3f7ade6 Reviewed-on: http://gerrit.cloudera.org:8080/23461 Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Abhishek Chennaka <[email protected]> --- M src/kudu/common/CMakeLists.txt A src/kudu/common/array_cell_view.h A src/kudu/common/array_type_serdes-test.cc A src/kudu/common/array_type_serdes.h M src/kudu/common/types-test.cc M src/kudu/common/types.h M src/kudu/util/bitmap-test.cc M src/kudu/util/bitmap.cc M src/kudu/util/bitmap.h 9 files changed, 1,215 insertions(+), 8 deletions(-) Approvals: Alexey Serbin: Verified Abhishek Chennaka: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/23461 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7384580ea9eaa37e6f49dbc9746d9994c3f7ade6 Gerrit-Change-Number: 23461 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Xuebin Su <[email protected]>
