Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23447 )

Change subject: [thirdparty] upgrade cpplint up to 1.6.1 release
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/23447/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23447/3//COMMIT_MSG@18
PS3, Line 18: 2.0.x release line is not quite stable yet
> Do you have specific evidence of instability, or is this more of a conserva
Sure: the cadence of patch releases was a part of such evidence for me.  Just 
look at the cadence of 2.0.x releases.  Per description, 2.0.2 is a hotfix 
release, and 2.0.1 was a bugfix release as well.

Also, take a look at the big date gap between 1.6.1 and 2.0.0 releases.  All 
this is telling me that switching to 2.0.x branch right now isn't the best bet, 
even if assuming we are about to drop Python2 and Python3.7 support in Kudu in 
the nearest future.

As for particular behavior and the functionality of the cpplint tool in the 
2.0.x branch, I haven't even tried it because the dropped support of Python2 
and Python 3.7 was already a no-go criterion for me.


http://gerrit.cloudera.org:8080/#/c/23447/3/thirdparty/vars.sh
File thirdparty/vars.sh:

http://gerrit.cloudera.org:8080/#/c/23447/3/thirdparty/vars.sh@124
PS3, Line 124: git co 1.6.1
> nit: For better clarity and copy-pasteable documentation, consider using th
Done



--
To view, visit http://gerrit.cloudera.org:8080/23447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I390dad51e8e0a57e5823ad789f7f8b0029e5bdb4
Gerrit-Change-Number: 23447
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Gabriella Lotz <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Comment-Date: Tue, 23 Sep 2025 00:42:01 +0000
Gerrit-HasComments: Yes

Reply via email to