Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23563 )
Change subject: KUDU-1261 [Java] Add PartialRow.getArrayData() ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/23563/3/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java File java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java: http://gerrit.cloudera.org:8080/#/c/23563/3/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@955 PS3, Line 955: * @throws IllegalArgumentException if the column is not an array type > nit: add the Nullable annotation? Done http://gerrit.cloudera.org:8080/#/c/23563/3/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@956 PS3, Line 956: > nit: in addition to verifying the type of the column cell, does it make sen Done http://gerrit.cloudera.org:8080/#/c/23563/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java: http://gerrit.cloudera.org:8080/#/c/23563/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java@309 PS3, Line 309: assertEquals("foo", view.getString(0)); > Is it possible to unify this across all the various scenarios? If not, ple Yes, updated this accordingly. -- To view, visit http://gerrit.cloudera.org:8080/23563 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I55e7ecfc6876c8aba5f15232d570617ad008f772 Gerrit-Change-Number: 23563 Gerrit-PatchSet: 4 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 21 Oct 2025 20:10:24 +0000 Gerrit-HasComments: Yes
