Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23483 )

Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................


Patch Set 18:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23483/18/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java
File java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java:

http://gerrit.cloudera.org:8080/#/c/23483/18/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java@150
PS18, Line 150: int vlen = content.validityLength();
> Isn't this number of bytes?  Meanwhile, the comparison at line 156 hints it
Ah, sorry -- please ignore this.

Whoops, I confused it with the other context, when validity is already a bitset 
:)



--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 18
Gerrit-Owner: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
Gerrit-Comment-Date: Thu, 23 Oct 2025 00:08:34 +0000
Gerrit-HasComments: Yes

Reply via email to