Abhishek Chennaka has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23483 )

Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................


Patch Set 17:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/23483/18/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
File java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java:

http://gerrit.cloudera.org:8080/#/c/23483/18/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@762
PS18, Line 762:   protected byte[] getArrayBytes(int columnIndex) {
> nit: annotate as Nullable?
Done


http://gerrit.cloudera.org:8080/#/c/23483/18/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@841
PS18, Line 841:   public final Object getArrayData(int columnIndex) {
> nit: annotate this method as Nullable?
Done


http://gerrit.cloudera.org:8080/#/c/23483/18/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@866
PS18, Line 866:   public final Object getArrayData(String columnName) {
> nit: annotate this method as Nullable?
Done


http://gerrit.cloudera.org:8080/#/c/23483/18/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java:

http://gerrit.cloudera.org:8080/#/c/23483/18/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@2440
PS18, Line 2440:
> Here and below: I guess the prevalent use case would be supplying null inst
Done



--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 17
Gerrit-Owner: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
Gerrit-Comment-Date: Thu, 23 Oct 2025 01:47:10 +0000
Gerrit-HasComments: Yes

Reply via email to