Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23565 )
Change subject: KUDU-1261 [Java] Add spark bindings for Array columns ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/23565/12/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala File java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala: http://gerrit.cloudera.org:8080/#/c/23565/12/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@1182 PS12, Line 1182: Objects.equal(before.getName, after.getName) && : Objects.equal(before.getType, after.getType) && : Objects.equal(before.isKey, after.isKey) && : Objects.equal(before.isNullable, after.isNullable) && : defaultValuesMatch(before.getDefaultValue, after.getDefaultValue) && : Objects.equal(before.getDesiredBlockSize, after.getDesiredBlockSize) && : Objects.equal(before.getEncoding, after.getEncoding) && : Objects : .equal(before.getCompressionAlgorithm, after.getCompressionAlgorithm) && : Objects.equal(before.getTypeAttributes, after.getTypeAttributes) && : Objects.equal(before.getComment, after.getComment) && : Objects.equal(before.isArray, after.isArray) Just curious: isn't it possible to use ColumnSchema.equal() here instead this re-implementation of the equal() method for ColumnSchema? -- To view, visit http://gerrit.cloudera.org:8080/23565 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I786fdd1cbfbb67b4895b2e95b89addbc04341746 Gerrit-Change-Number: 23565 Gerrit-PatchSet: 12 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 24 Oct 2025 06:07:12 +0000 Gerrit-HasComments: Yes
