Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23565 )
Change subject: KUDU-1261 [Java] Add spark bindings for Array columns ...................................................................... Patch Set 13: (3 comments) http://gerrit.cloudera.org:8080/#/c/23565/12/java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala File java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala: http://gerrit.cloudera.org:8080/#/c/23565/12/java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala@272 PS12, Line 272: IllegalArgumentExcept > nit: would IllegalArgumentException be a better choice? From where does th Done http://gerrit.cloudera.org:8080/#/c/23565/12/java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala@277 PS12, Line 277: IllegalArgumentExcept > Also, IllegalArgumentException might be even a better choice than Unsupport Done http://gerrit.cloudera.org:8080/#/c/23565/12/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala File java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala: http://gerrit.cloudera.org:8080/#/c/23565/12/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@1182 PS12, Line 1182: Objects.equal(before.getName, after.getName) && : Objects.equal(before.getType, after.getType) && : Objects.equal(before.isKey, after.isKey) && : Objects.equal(before.isNullable, after.isNullable) && : defaultValuesMatch(before.getDefaultValue, after.getDefaultValue) && : Objects.equal(before.getDesiredBlockSize, after.getDesiredBlockSize) && : Objects.equal(before.getEncoding, after.getEncoding) && : Objects : .equal(before.getCompressionAlgorithm, after.getCompressionAlgorithm) && : Objects.equal(before.getTypeAttributes, after.getTypeAttributes) && : Objects.equal(before.getComment, after.getComment) && : Objects.equal(before.isArray, after.isArray) > Just curious: isn't it possible to use ColumnSchema.equal() here instead th The current implementation of ColumnSchema.equals() doesn't check all the fields. Not sure the background behind it, but that seems to be the reason. return Objects.equals(name, that.name) && Objects.equals(type, that.type) && Objects.equals(key, that.key) && Objects.equals(keyUnique, that.keyUnique) && Objects.equals(autoIncrementing, that.autoIncrementing) && Objects.equals(typeAttributes, that.typeAttributes) && Objects.equals(comment, that.comment) && Objects.equals(nestedTypeDescriptor, that.nestedTypeDescriptor); -- To view, visit http://gerrit.cloudera.org:8080/23565 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I786fdd1cbfbb67b4895b2e95b89addbc04341746 Gerrit-Change-Number: 23565 Gerrit-PatchSet: 13 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 24 Oct 2025 15:31:58 +0000 Gerrit-HasComments: Yes
