Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23605 )

Change subject: [Java] Resolve ClassNotFoundException: kudu.DefaultSource
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/23605/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23605/1//COMMIT_MSG@16
PS1, Line 16: has been tested manually
Could you clarify what was tested and how you tested it?

Also, I'm curious whether the following works with this patch:
  * signing Java artifacts
  * publishing Java artifacts


http://gerrit.cloudera.org:8080/#/c/23605/1//COMMIT_MSG@16
PS1, Line 16: addresses these issues
Does it bring any unwanted dependencies?  IIRC, all this fun with minimize() 
was to get rid of unexpected dependencies introduced when switching to the new 
Gradle (version 7.6.4) in e456bc775805d4555d99ce12d04e3ca0b8950760, so I'm 
curious what is the result when removing these minimize-related provisions.


http://gerrit.cloudera.org:8080/#/c/23605/1//COMMIT_MSG@18
PS1, Line 18: ERROR yarn.Client: [main]: Application diagnostics message:
Where did this come from, i.e. how did you find this?

If it's possible, could you please outline the essence why this wasn't detected 
by the pre-commit tests we currently have in the gerrit/jenkins CI pipeline?

Do you think it would be possible to add an automated test to spot the problem 
like this during tests run in the pre-commit CI pipeline?  What are we missing 
as of now to make this happen?

Thank you!



--
To view, visit http://gerrit.cloudera.org:8080/23605
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0b8f07ea46759dc92d5ed2105a5480a0cf56464
Gerrit-Change-Number: 23605
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
Gerrit-Comment-Date: Tue, 28 Oct 2025 20:05:21 +0000
Gerrit-HasComments: Yes

Reply via email to