Abhishek Chennaka has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23605 )

Change subject: [Java] Resolve ClassNotFoundException: kudu.DefaultSource
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/23605/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23605/1//COMMIT_MSG@16
PS1, Line 16: addresses these issues
> Does it bring any unwanted dependencies?  IIRC, all this fun with minimize(
I didn't find any unwanted dependencies. These are the list of 45 classes that 
will be included in the final kudu-spark-tools.jar with this change:

org/apache/kudu/util/BloomFilter$HashFunction.class
org/apache/kudu/util/HashUtil.class
org/apache/kudu/util/BloomFilter$HashFunctions.class
org/apache/kudu/util/BloomFilter$HashFunctions$1.class
org/apache/kudu/util/BloomFilter$1.class
org/apache/kudu/util/BloomFilter.class
org/apache/kudu/client/ListTabletsRequest.class
org/apache/kudu/client/ListTabletsResponse.class
META-INF/services/
META-INF/services/reactor.blockhound.integration.BlockHoundIntegration
org/apache/kudu/spark/kudu/Update.class
org/apache/kudu/spark/kudu/Upsert.class
org/apache/kudu/spark/kudu/KuduSink$.class
org/apache/kudu/spark/kudu/MapAccumulator$.class
org/apache/kudu/spark/kudu/Delete.class
org/apache/kudu/spark/kudu/DefaultSource.class
org/apache/kudu/spark/kudu/Insert.class
org/apache/kudu/spark/kudu/DeleteIgnore.class
org/apache/kudu/spark/kudu/UpdateIgnore.class
org/apache/kudu/spark/kudu/package$KuduDataFrameWriter.class
org/apache/kudu/spark/kudu/package.class
org/apache/kudu/spark/kudu/package$KuduDataFrameReader.class
org/apache/kudu/spark/kudu/SparkUtil.class
org/apache/kudu/spark/kudu/KuduSink.class
org/apache/kudu/spark/kudu/InsertIgnore.class
org/apache/kudu/spark/kudu/package$.class
META-INF/services/org.apache.spark.sql.sources.DataSourceRegister
org/apache/yetus/audience/tools/
org/apache/yetus/audience/tools/StabilityOptions.class
org/apache/yetus/audience/tools/IncludePublicAnnotationsStandardDoclet.class
org/apache/yetus/audience/tools/ExcludePrivateAnnotationsStandardDoclet.class
org/apache/yetus/audience/tools/RootDocProcessor.class
org/apache/yetus/audience/tools/RootDocProcessor$ExcludeHandler.class
org/apache/kudu/shaded/scopt/OEffect$.class
org/apache/kudu/shaded/scopt/OParser$$anon$1.class
org/apache/kudu/shaded/scopt/OParser$$anon$2.class
org/apache/kudu/shaded/scopt/OParser$$anon$3.class
org/apache/kudu/shaded/scopt/OParser$.class
org/apache/kudu/shaded/scopt/OParser.class
org/apache/kudu/shaded/scopt/OParserBuilder.class
org/apache/kudu/shaded/scopt/ORunner.class
org/apache/kudu/shaded/scopt/OptionDefKind$.class
org/apache/kudu/shaded/scopt/RenderingMode$.class
org/apache/kudu/shaded/scopt/Seq.class
org/apache/kudu/shaded/scopt/Validation.class


http://gerrit.cloudera.org:8080/#/c/23605/1//COMMIT_MSG@16
PS1, Line 16: has been tested manually
> Could you clarify what was tested and how you tested it?
With this commit in place, the listed files are present in the published jars.
The build-support/verify_jars.pl did not list any issues and no issues seen 
when signing and publishing artifacts either.


http://gerrit.cloudera.org:8080/#/c/23605/1//COMMIT_MSG@18
PS1, Line 18: ERROR yarn.Client: [main]: Application diagnostics message:
> Where did this come from, i.e. how did you find this?
This was found as a part of testing done at Cloudera where kudu-spark jars were 
used to run spark jobs for basic functionality testing.
We don't have such tests in Kudu repo as we do not have such a framework where 
we run spark jobs using the published jars.
This functionality needs to be added to our existing test suite, but since it 
is not a trivial task, it needs to be done as a part of a different change list.



--
To view, visit http://gerrit.cloudera.org:8080/23605
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0b8f07ea46759dc92d5ed2105a5480a0cf56464
Gerrit-Change-Number: 23605
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
Gerrit-Comment-Date: Fri, 07 Nov 2025 22:58:48 +0000
Gerrit-HasComments: Yes

Reply via email to