Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23606 )

Change subject: KUDU-3662: Fix shading in kudu-replication
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/23606/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23606/1//COMMIT_MSG@27
PS1, Line 27: https://nightlies.apache.org/flink/flink-docs-stable/docs/dev/
            : datastream/project-configuration/
This returns HTTP 404 as of 2025-10-29.  Is this link outdated?


http://gerrit.cloudera.org:8080/#/c/23606/1/java/kudu-replication/build.gradle
File java/kudu-replication/build.gradle:

http://gerrit.cloudera.org:8080/#/c/23606/1/java/kudu-replication/build.gradle@29
PS1, Line 29: 
https://nightlies.apache.org/flink/flink-docs-stable/docs/dev/datastream/project-configuration/
This  returns HTTP 404 'Not Found' as of 2025-10-29.  Is this link outdated?


http://gerrit.cloudera.org:8080/#/c/23606/1/java/kudu-replication/build.gradle@35
PS1, Line 35:     // Bundle flink-connector-kudu but exclude its kudu-client to 
avoid duplicates
            :     implementation(libs.flinkConnectorKudu) {
Why is this needed at all if kudu-client is capable of talking Kudu API and the 
rest of the Flink core functionality is provided by the components listed above 
with 'compileUnshaded' configuration?  This looks strange to me.



--
To view, visit http://gerrit.cloudera.org:8080/23606
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I57660c7c97fd440309f69f5d5e0d028aa88042dc
Gerrit-Change-Number: 23606
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Gabriella Lotz <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
Gerrit-Comment-Date: Thu, 30 Oct 2025 07:10:24 +0000
Gerrit-HasComments: Yes

Reply via email to