Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/23606 )
Change subject: KUDU-3662: Fix shading in kudu-replication ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/23606/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23606/1//COMMIT_MSG@27 PS1, Line 27: https://nightlies.apache.org/flink/flink-docs-release-1.20/docs/dev/ : configuration/overview/ > This returns HTTP 404 as of 2025-10-29. Is this link outdated? Updated the link to the LTS docs link. http://gerrit.cloudera.org:8080/#/c/23606/1/java/kudu-replication/build.gradle File java/kudu-replication/build.gradle: http://gerrit.cloudera.org:8080/#/c/23606/1/java/kudu-replication/build.gradle@29 PS1, Line 29: https://nightlies.apache.org/flink/flink-docs-release-1.20/docs/dev/configuration/overview/ > This returns HTTP 404 'Not Found' as of 2025-10-29. Is this link outdated Updated the link. http://gerrit.cloudera.org:8080/#/c/23606/1/java/kudu-replication/build.gradle@35 PS1, Line 35: // Bundle flink-connector-kudu but exclude its kudu-client to avoid duplicates : implementation(libs.flinkConnectorKudu) { > Why is this needed at all if kudu-client is capable of talking Kudu API and flink-connector-kudu provides the Flink-specific integration layer (e.g., KuduSource, KuduSink, KuduReaderConfig, KuduWriterConfig, split enumeration, checkpointing) that bridges Flink's DataStream API with Kudu. Per Flink's packaging guidelines, connectors should be bundled in the job JAR, while Flink core APIs (marked compileUnshaded) are provided by the cluster at runtime. We exclude kudu-client from the connector to avoid having duplicate kudu-client classes on the classpath, since we're already explicitly bundling our own shaded version. Without the exclusion, both the connector's transitive dependency and our explicit dependency would be present, causing classpath conflicts. -- To view, visit http://gerrit.cloudera.org:8080/23606 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57660c7c97fd440309f69f5d5e0d028aa88042dc Gerrit-Change-Number: 23606 Gerrit-PatchSet: 2 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 30 Oct 2025 13:32:20 +0000 Gerrit-HasComments: Yes
