Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23649 )
Change subject: [docs] refresh `kudu master add` documentation ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/23649/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23649/1//COMMIT_MSG@21 PS1, Line 21: people > nit: users Done http://gerrit.cloudera.org:8080/#/c/23649/1/docs/administration.adoc File docs/administration.adoc: http://gerrit.cloudera.org:8080/#/c/23649/1/docs/administration.adoc@550 PS1, Line 550: or five node master > Move to next line Done http://gerrit.cloudera.org:8080/#/c/23649/1/docs/administration.adoc@581 PS1, Line 581: Define and record all the rest of the customized flags the new master should : run with once added into the cluster. > Should we also add a one liner or modify this to advise users to record the I guess it's just one of the ways to create the list of the flags for a new master: there might be different approaches. I think we better leave this generic part out of the picture, focusing on specifics: the section isn't focusing on best practices per se, but rather on essential steps to successfully add a new Kudu master using the `kudu master add` tool. http://gerrit.cloudera.org:8080/#/c/23649/1/docs/administration.adoc@598 PS1, Line 598: file. > Move to next line Done http://gerrit.cloudera.org:8080/#/c/23649/1/docs/administration.adoc@601 PS1, Line 601: is shutdown > is still in a shutdown state? I guess it's an attempt to explain that the procedure runs a new master (i.e. kudu-master process), and then it shuts the new master down regardless of the success/failure outcome. I rephrased it a bit, hopefully it's clear now. http://gerrit.cloudera.org:8080/#/c/23649/1/docs/administration.adoc@610 PS1, Line 610: run > run with ? Done -- To view, visit http://gerrit.cloudera.org:8080/23649 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d2ae84d596a0c3ffe840cc16d3ac0d0d28d05bc Gerrit-Change-Number: 23649 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 07 Nov 2025 23:00:40 +0000 Gerrit-HasComments: Yes
