Ashwani Raina has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23657 )

Change subject: [webserver] Restrict UI pages to GET/HEAD methods only
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23657/1/src/kudu/server/webserver.cc
File src/kudu/server/webserver.cc:

http://gerrit.cloudera.org:8080/#/c/23657/1/src/kudu/server/webserver.cc@746
PS1, Line 746: display pages (StyleMode::STYLED)
How does style mode set to 'STYLED' enforce that page is for display purposes 
only? Is it possible that style mode is set to STYLED and http methods like 
PUT/DELETE are still applicable?

It seems to be related to presence of additional styling elements in the 
response per this comment:
+++
// This mode includes additional styling elements in the response,
// such as CSS, navigation bar, etc.
STYLED,
// In this mode, the response is sent without any styling elements.
UNSTYLED,
// In rare cases when a binary data is sent as a response.
BINARY,
// This mode is used when the server response is in JSON format.
JSON
+++



--
To view, visit http://gerrit.cloudera.org:8080/23657
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie232bd50785bb750ecaa0a7e19403e573ac193eb
Gerrit-Change-Number: 23657
Gerrit-PatchSet: 1
Gerrit-Owner: Gabriella Lotz <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 12 Nov 2025 11:35:27 +0000
Gerrit-HasComments: Yes

Reply via email to