Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23657 )
Change subject: [webserver] Restrict UI pages to GET/HEAD methods only ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/23657/1/src/kudu/server/webserver.cc File src/kudu/server/webserver.cc: http://gerrit.cloudera.org:8080/#/c/23657/1/src/kudu/server/webserver.cc@749 PS1, Line 749: eq.request_method != "GET" && req.request_method != "HEAD" Just to clarify: OPTIONS method will be still allowed, but it's handled at lower level, right? If allowing just GET and HEAD methods, it would be nice to response to OPTIONS method for these endpoints correspondingly. Otherwise it would be inconsistent to respond to OPTIONS with all the methods available, but in fact limit the methods to GET and HEAD only. https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Methods/OPTIONS -- To view, visit http://gerrit.cloudera.org:8080/23657 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie232bd50785bb750ecaa0a7e19403e573ac193eb Gerrit-Change-Number: 23657 Gerrit-PatchSet: 1 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 22 Nov 2025 17:48:04 +0000 Gerrit-HasComments: Yes
