Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23689 )
Change subject: [util] remove chromium-based Atomics from env_posix.cc ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/23689/3/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: http://gerrit.cloudera.org:8080/#/c/23689/3/src/kudu/util/env_posix.cc@2017 PS3, Line 2017: __thread > Can we use 'thread_local' instead which is a standard C++ keyword? __thread is used in many other places in the code. If changing it to other notation like thread_local or _Thread_local, I'd rather do so everywhere in a separate changelist. http://gerrit.cloudera.org:8080/#/c/23689/3/src/kudu/util/env_posix.cc@2022 PS3, Line 2022: pre-increment is equivalent to 'cur_thread_local_id_.fetch_add(1) + 1' > Why not use 'fetch_add(1) + 1' instead? Because the pre-increment operator is more expressive and there isn't a need to customize memory ordering, at least. Why to use 'fetch_add(1) + 1' when there is the pre-increment operator? -- To view, visit http://gerrit.cloudera.org:8080/23689 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63d883de66c51d5d4a6c7eb1eebe63713f1f6dcc Gerrit-Change-Number: 23689 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Wed, 19 Nov 2025 22:44:15 +0000 Gerrit-HasComments: Yes
