Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23689 )
Change subject: [util] remove chromium-based Atomics from env_posix.cc ...................................................................... [util] remove chromium-based Atomics from env_posix.cc With this patch, Atomic64 and Barrier_AtomicIncrement() are no longer used in env_posix.cc: the logic of PosixEnv::gettid() is now implemented using std::atomic. Also, the global static and thread-local static variables are moved inside of the PosixEnv::gettid() method which is an improvement as well, according to Clang-Tidy. In addition, I added a new test scenario to verify that the generated thread identifiers are indeed unique. I didn't want to rely on existing CHECK()/DCHECK() assertions in various places for indirect verification of a few explicit invariants. Apart from the new test scenario, there are no functional modifications in this changelist. Change-Id: I63d883de66c51d5d4a6c7eb1eebe63713f1f6dcc Reviewed-on: http://gerrit.cloudera.org:8080/23689 Tested-by: Kudu Jenkins Reviewed-by: Ashwani Raina <[email protected]> Reviewed-by: Marton Greber <[email protected]> --- M src/kudu/util/env_posix.cc M src/kudu/util/mt-threadlocal-test.cc 2 files changed, 92 insertions(+), 8 deletions(-) Approvals: Kudu Jenkins: Verified Ashwani Raina: Looks good to me, but someone else must approve Marton Greber: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/23689 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I63d883de66c51d5d4a6c7eb1eebe63713f1f6dcc Gerrit-Change-Number: 23689 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]>
