Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23529 )
Change subject: KUDU-1973 Enable some unit tests for heartbeat batching. ...................................................................... Patch Set 6: (2 comments) Overall looks good. Just a couple of nits. http://gerrit.cloudera.org:8080/#/c/23529/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23529/6//COMMIT_MSG@7 PS6, Line 7: some Why not include more tests (or maybe all of them under RaftConsensusITest if their runtime is within acceptable limits) for a better coverage, especially, multi-threaded ones? http://gerrit.cloudera.org:8080/#/c/23529/4/src/kudu/integration-tests/raft_consensus-itest.cc File src/kudu/integration-tests/raft_consensus-itest.cc: http://gerrit.cloudera.org:8080/#/c/23529/4/src/kudu/integration-tests/raft_consensus-itest.cc@252 PS4, Line 252: && GetParam > Done if (!gflags::GetCommandLineFlagInfoOrDie("enable_multi_raft_heartbeat_batcher").is_default && GetParam() != FLAGS_enable_multi_raft_heartbeat_batcher) { or better if (!gflags::GetCommandLineFlagInfoOrDie("enable_multi_raft_heartbeat_batcher").is_default && GetParam() != FLAGS_enable_multi_raft_heartbeat_batcher) { -- To view, visit http://gerrit.cloudera.org:8080/23529 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifd442b36b46c038fbf836f48feaa21b1ab296d82 Gerrit-Change-Number: 23529 Gerrit-PatchSet: 6 Gerrit-Owner: Zoltan Martonka <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Tue, 25 Nov 2025 11:24:59 +0000 Gerrit-HasComments: Yes
