Ashwani Raina has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23529 )

Change subject: KUDU-1973 Enable some unit tests for heartbeat batching.
......................................................................


Patch Set 6:

> Patch Set 6:
>
> > (2 comments)
>  >
>  > Overall looks good. Just a couple of nits.
>
> TSAN takes:
>  real 20m17.783s
> user  60m25.114s
> sys   5m43.909s
>
> Debug:
> real    12m46.252s
> user    20m11.526s
> sys     2m28.377s
>
> If you think adding this much for test is ok, then I can add make all tests 
> run with both state,
> but I found it a bit too much, that's why I picked 5.

This is definitely too much. Btw dist-cluster times are significantly less (at 
least for some of the tests that I ran for ipv6). You might wanna check the 
dist-cluster times as well.
Is this the additional time taken the tests that are included on top of what 
you already have added?


--
To view, visit http://gerrit.cloudera.org:8080/23529
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd442b36b46c038fbf836f48feaa21b1ab296d82
Gerrit-Change-Number: 23529
Gerrit-PatchSet: 6
Gerrit-Owner: Zoltan Martonka <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
Gerrit-Reviewer: Zoltan Martonka <[email protected]>
Gerrit-Comment-Date: Tue, 09 Dec 2025 15:13:11 +0000
Gerrit-HasComments: No

Reply via email to