Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23740 )
Change subject: Fix clean TSAN build. ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/23740/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23740/1//COMMIT_MSG@9 PS1, Line 9: If you run: : git clean -xfd (or start with a clean vm). : BUILD_TYPE=TSAN ./build-support/jenkins/build-and-test.sh : : It fails, because thirdparty/installed/uninstrumented/bin/flatc : is hardwired in java/kudu-flatbuffers/build.gradle. > I'd think we have similar issue with protobuf compiler, no? Why is this d It uses a binary from maven, in java/gradle/protobuf.gradle: // If -PuseKuduProtoc is set, use the protoc from Kudu's thirdparty instead // of using the protoc Maven artifacts. This is useful if a specific // OS or architecture is not published to Maven. So maybe I should change that to common as well. But clean TSAN build unless you set this flag. http://gerrit.cloudera.org:8080/#/c/23740/1//COMMIT_MSG@16 PS1, Line 16: There is no reason to include the tsan version instead. > For both protobuf and flatc, there are sanitizer-related flags that affect So in case of TSAN build we should generate the java classes with a TSAN instrumented flatc executable? Won't it generate exactly the same for java? http://gerrit.cloudera.org:8080/#/c/23740/1/thirdparty/build-thirdparty.sh File thirdparty/build-thirdparty.sh: http://gerrit.cloudera.org:8080/#/c/23740/1/thirdparty/build-thirdparty.sh@402 PS1, Line 402: # Java build always uses the uninstrumented version. : if [ -n "$F_COMMON" -o -n "$F_FLATBUFFERS" ]; then > What's the with code at line 585-587 if modifying this? Its fine: Normal build: + Uninstrumented for everything TSAN build: + Uninstrumented for generating the java classes. + TSAN version for everything else. -- To view, visit http://gerrit.cloudera.org:8080/23740 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id45e8c98e43df7d769a87b41e50f4781ca234061 Gerrit-Change-Number: 23740 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Martonka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Thu, 04 Dec 2025 09:10:58 +0000 Gerrit-HasComments: Yes
