Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23740 )
Change subject: Fix clean TSAN build. ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/23740/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23740/1//COMMIT_MSG@16 PS1, Line 16: There is no reason to include the tsan version instead. > So in case of TSAN build we should generate the java classes with a TSAN in Yes, that is true, the generated java classes won't be affected. But if we have reasons to use the TSAN built flatc for generating Java classes, we probably have to go that route. Not sure the exact changes needed for that though. -- To view, visit http://gerrit.cloudera.org:8080/23740 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id45e8c98e43df7d769a87b41e50f4781ca234061 Gerrit-Change-Number: 23740 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Martonka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Mon, 08 Dec 2025 20:01:16 +0000 Gerrit-HasComments: Yes
