Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23726
to look at the new patch set (#2).
Change subject: KUDU-3722 unit mismatch in ProceedWithFlush
......................................................................
KUDU-3722 unit mismatch in ProceedWithFlush
MaintenanceManager's ProceedWithFlush function uses units inconsistent
with process_memory::UnderMemoryPressure when checking memory pressure:
soft_limit and pressure_threshold are treated as decimals (0–1)
while used_memory_percentage is a percentage (0–100). This causes
ProceedWithFlush to always return true once memory usage exceeds
memory_pressure_percentage, which is not the intended behavior
introduced by KUDU-3407.
This patch converts soft_limit and pressure_threshold to percentages,
replaces division with an equivalent multiplication form, and updates
the relevant tests.
Change-Id: Icb4c299a83c61bd934d67f32446696988bbe3a08
---
M src/kudu/util/maintenance_manager-test.cc
M src/kudu/util/maintenance_manager.cc
2 files changed, 23 insertions(+), 20 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/23726/2
--
To view, visit http://gerrit.cloudera.org:8080/23726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icb4c299a83c61bd934d67f32446696988bbe3a08
Gerrit-Change-Number: 23726
Gerrit-PatchSet: 2
Gerrit-Owner: Yongheng Deng <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
