Yongheng Deng has posted comments on this change. ( http://gerrit.cloudera.org:8080/23726 )
Change subject: KUDU-3722 unit mismatch in ProceedWithFlush ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/23726/1/src/kudu/util/maintenance_manager-test.cc File src/kudu/util/maintenance_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/23726/1/src/kudu/util/maintenance_manager-test.cc@352 PS1, Line 352: sure_threshold = FL > nit for here and below: it's safe to remove static_cast, isn't it? Done http://gerrit.cloudera.org:8080/#/c/23726/1/src/kudu/util/maintenance_manager.cc File src/kudu/util/maintenance_manager.cc: http://gerrit.cloudera.org:8080/#/c/23726/1/src/kudu/util/maintenance_manager.cc@724 PS1, Line 724: if (!process_memory::UnderMemoryPressure(used_memory_percentage)) { : return false; : } : : static const double pressure_threshold = FLAGS_memory_pressure_percentage; : static const double soft_limit = FLAGS_memory_limit_soft_percentage; : static const double pressure_diff = soft_limit - pressure_threshold; : const double used_diff = soft_limit - *used_memory_percentage; : > I'd suggest to update the implementation of this method a bit. There is a Thanks for the suggestion! I've updated the implementation following your approach. -- To view, visit http://gerrit.cloudera.org:8080/23726 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icb4c299a83c61bd934d67f32446696988bbe3a08 Gerrit-Change-Number: 23726 Gerrit-PatchSet: 2 Gerrit-Owner: Yongheng Deng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yongheng Deng <[email protected]> Gerrit-Comment-Date: Fri, 05 Dec 2025 04:17:13 +0000 Gerrit-HasComments: Yes
