Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/23711 )
Change subject: KUDU-1457 [7/n] Use correct URL host for ip mode ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/23711/1/src/kudu/server/webserver-test.cc File src/kudu/server/webserver-test.cc: http://gerrit.cloudera.org:8080/#/c/23711/1/src/kudu/server/webserver-test.cc@146 PS1, Line 146: if (mode_ == IPMode::IPV6) { : // For 'IPV6' mode, set IPv6 loopback address as URL host. : ASSERT_OK(addr_.ParseString("[::1]", addrs[0].port())); : } else { : // For both IPV4 and DUAL mode, choose IPv4 loopback address as URL host. : // Both are expected to work with IPv4 loopback address. : ASSERT_OK(addr_.ParseString("127.0.0.1", addrs[0].port())); : } In DUAL mode, the server binds to [::] but the test connects via 127.0.0.1. Would it be more consistent to use [::1] for both DUAL and IPV6 modes since both bind to [::]? Or is there a specific reason to test IPv4 connectivity in DUAL mode? -- To view, visit http://gerrit.cloudera.org:8080/23711 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I152b0755f286edce1738683b5d2cdf5804f4ff2a Gerrit-Change-Number: 23711 Gerrit-PatchSet: 1 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Wed, 17 Dec 2025 15:49:12 +0000 Gerrit-HasComments: Yes
