Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23711 )
Change subject: KUDU-1457 [7/n] Use correct URL host for ip mode ...................................................................... Patch Set 2: (1 comment) > Patch Set 1: > > (1 comment) Added more test coverage. http://gerrit.cloudera.org:8080/#/c/23711/1/src/kudu/server/webserver-test.cc File src/kudu/server/webserver-test.cc: http://gerrit.cloudera.org:8080/#/c/23711/1/src/kudu/server/webserver-test.cc@146 PS1, Line 146: if (mode_ == IPMode::IPV4) { : // For 'IPV4' mode, set IPv4 loopback address as URL host. : ASSERT_OK(addr_.ParseString("127.0.0.1", addrs[0].port())); : } else { : // For both IPV6 and DUAL mode, choose IPv6 loopback address as URL host. : // Both are expected to work with IPv6 loopback address. : ASSERT_OK(addr_.ParseString("[::1]", addrs[0].port())); : } > In DUAL mode, the server binds to [::] but the test connects via 127.0.0.1. It doesn't really matter as long as basic connectivity rules of IP modes are not violated. For a dual mode, one can use any of the two (127.0.0.1 or ::1) for connection. The main reason to use IPv4 loopback for dual mode is to keep using current configuration (like service principal name, trusted certificate subject name) for tests. I have updated the test coverage to include more tests to cover ip config modes. Now that, all that configuration is tunable based on ip config modes, having ::1 as address for DUAL and IPV6 is also added. Please check PS2. -- To view, visit http://gerrit.cloudera.org:8080/23711 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I152b0755f286edce1738683b5d2cdf5804f4ff2a Gerrit-Change-Number: 23711 Gerrit-PatchSet: 2 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Wed, 31 Dec 2025 07:18:22 +0000 Gerrit-HasComments: Yes
