Zoltan Martonka has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/23928


Change subject: WIP split eh frames into singe FDEs
......................................................................

WIP split eh frames into singe FDEs

WIP Todo:
  + Normal commit message
  + Test on the actual quasar cluster
  + Test with old glibc version.

This would fix the codegen crash with new libgcc.

Compared to the other approach
(custom implementation of the section memory manager)

Pros:
+ Don't need to rely on estimating the required space.
+ No mmap magic.
+ Toggle runtime.

Cons:
+ Might slow donw unwinding on old libgcc.
+ 300 lines of code to parse and rewrite FDEs (to fix relative
pointers). 
(https://refspecs.linuxfoundation.org/LSB_3.0.0/LSB-Core-generic/LSB-Core-generic/ehframechpt.html)
+ Addtional memory usage for copying eh_frames (probably insignificant).

Change-Id: I2bfd755e183f20bfce66b40c7fc1d61d8bce0764
---
M src/kudu/codegen/jit_frame_manager.cc
M src/kudu/codegen/jit_frame_manager.h
2 files changed, 327 insertions(+), 22 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/23928/1
--
To view, visit http://gerrit.cloudera.org:8080/23928
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2bfd755e183f20bfce66b40c7fc1d61d8bce0764
Gerrit-Change-Number: 23928
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Martonka <[email protected]>

Reply via email to