Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23928 )
Change subject: WIP split eh frames into singe FDEs ...................................................................... Patch Set 1: (3 comments) Thanks a lot for driving this to the finish line! This isn't a trivial approach, it seems. At least, it's quite involved if talking about the details of ELF EH frame structure and layout. I took a quick look an realized I'll need to get much context on ELF EH frame format to provide any meaningful feedback. As of now, just posting a few nits. Feel free to ignore those. Also, I found this review item already abandoned as of February 3, 2026. I assume this means you aren't expecting any review feedback, let me know if you are expecting otherwise. http://gerrit.cloudera.org:8080/#/c/23928/1/src/kudu/codegen/jit_frame_manager.h File src/kudu/codegen/jit_frame_manager.h: http://gerrit.cloudera.org:8080/#/c/23928/1/src/kudu/codegen/jit_frame_manager.h@28 PS1, Line 28: nit: remove the unintentionally added empty lines? http://gerrit.cloudera.org:8080/#/c/23928/1/src/kudu/codegen/jit_frame_manager.h@54 PS1, Line 54: > > nit: with C++17-capable compilers (at least with contemporary CLANG and GCC versions) there isn't a need to add extra spaces to separate '>' http://gerrit.cloudera.org:8080/#/c/23928/1/src/kudu/codegen/jit_frame_manager.cc File src/kudu/codegen/jit_frame_manager.cc: http://gerrit.cloudera.org:8080/#/c/23928/1/src/kudu/codegen/jit_frame_manager.cc@24 PS1, Line 24: #include <llvm/ExecutionEngine/SectionMemoryManager.h> : #include <gflags/gflags.h> : #include <kudu/util/logging.h> : #include <kudu/util/flag_tags.h> nit: re-arrange the headers alphabetically -- To view, visit http://gerrit.cloudera.org:8080/23928 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2bfd755e183f20bfce66b40c7fc1d61d8bce0764 Gerrit-Change-Number: 23928 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Martonka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Tue, 03 Feb 2026 22:25:29 +0000 Gerrit-HasComments: Yes
