Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23925 )
Change subject: KUDU-3736 fix SIGSEGV in codegen with libgcc-11.5.0-10+ ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Looks good. I think we should go ahead with this solution. http://gerrit.cloudera.org:8080/#/c/23925/2/src/kudu/codegen/jit_frame_manager.cc File src/kudu/codegen/jit_frame_manager.cc: http://gerrit.cloudera.org:8080/#/c/23925/2/src/kudu/codegen/jit_frame_manager.cc@161 PS2, Line 161: const size_t code_required_size_bytes = : code_align * ((code_size + code_align - 1) / code_align); : const size_t ro_data_required_size_bytes = : ro_data_align * ((ro_data_size + ro_data_align - 1) / ro_data_align); : const size_t rw_data_required_size_bytes = : rw_data_align * ((rw_data_size + rw_data_align - 1) / rw_data_align); : : // Extra safety margin: pre-allocate 2 times more, aligning up the the memory : // page size for each section type. : const size_t required_size_bytes = 2 * ( : page_size * ((code_required_size_bytes + page_size - 1) / page_size) + : page_size * ((ro_data_required_size_bytes + page_size - 1) / page_size) + : page_size * ((rw_data_required_size_bytes + page_size - 1) / page_size)); [nit] I think making a labda auto align_up = [](int x, int alignment) { return (x + alignment -1)/ alignment * alignment; }; would increase readability for using it 6 places. But it is just my subjective preference, so feel free to ignore this. -- To view, visit http://gerrit.cloudera.org:8080/23925 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I691d2f442c3148f235847c4c8e56767577804b1a Gerrit-Change-Number: 23925 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Mon, 02 Feb 2026 21:57:57 +0000 Gerrit-HasComments: Yes
