Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23925 )
Change subject: KUDU-3736 fix SIGSEGV in codegen with libgcc-11.5.0-10+ ...................................................................... Patch Set 4: Code-Review+1 (4 comments) LGTM! Just a few nits. http://gerrit.cloudera.org:8080/#/c/23925/3/src/kudu/codegen/jit_frame_manager.h File src/kudu/codegen/jit_frame_manager.h: http://gerrit.cloudera.org:8080/#/c/23925/3/src/kudu/codegen/jit_frame_manager.h@95 PS3, Line 95: remaining http://gerrit.cloudera.org:8080/#/c/23925/2/src/kudu/codegen/jit_frame_manager.cc File src/kudu/codegen/jit_frame_manager.cc: http://gerrit.cloudera.org:8080/#/c/23925/2/src/kudu/codegen/jit_frame_manager.cc@221 PS2, Line 221: EQ(0, memory_range_.al nit: Here and below. Why not call this only after null check for result to avoid unnecessary function call overhead? http://gerrit.cloudera.org:8080/#/c/23925/2/src/kudu/codegen/jit_frame_manager.cc@230 PS2, Line 230: memory_range_.allocatedSize() != 0; : } : : // nit: Maybe consolidate this and above instance into one template helper function that takes corresponding function pointer (SectionMemoryManager::allocateDataSection , SectionMemoryManager::allocateCodeSection ) as an argument? The same helper can run post allocation check as well after that. http://gerrit.cloudera.org:8080/#/c/23925/3/src/kudu/codegen/jit_frame_manager.cc File src/kudu/codegen/jit_frame_manager.cc: http://gerrit.cloudera.org:8080/#/c/23925/3/src/kudu/codegen/jit_frame_manager.cc@157 PS3, Line 157: // ranges must increase. Is it possible that there are some pre-allocated bytes left but not enough to satisfy the requirements? -- To view, visit http://gerrit.cloudera.org:8080/23925 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I691d2f442c3148f235847c4c8e56767577804b1a Gerrit-Change-Number: 23925 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Tue, 03 Feb 2026 08:45:37 +0000 Gerrit-HasComments: Yes
