Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23925 )
Change subject: KUDU-3736 fix SIGSEGV in codegen with libgcc-11.5.0-10+ ...................................................................... Patch Set 5: Code-Review+1 (3 comments) Given the urgency of this fix, it would be great to have some unit tests added for this that verify boundary, alignment, concurrency (wherever applicable) conditions in a separate patch. http://gerrit.cloudera.org:8080/#/c/23925/5/src/kudu/codegen/jit_frame_manager.cc File src/kudu/codegen/jit_frame_manager.cc: http://gerrit.cloudera.org:8080/#/c/23925/5/src/kudu/codegen/jit_frame_manager.cc@76 PS5, Line 76: (if present) When is it expected to be present? http://gerrit.cloudera.org:8080/#/c/23925/5/src/kudu/codegen/jit_frame_manager.cc@110 PS5, Line 110: (num_bytes + page_size - 1) nit: do you think overflow check is required before this? http://gerrit.cloudera.org:8080/#/c/23925/5/thirdparty/download-thirdparty.sh File thirdparty/download-thirdparty.sh: http://gerrit.cloudera.org:8080/#/c/23925/5/thirdparty/download-thirdparty.sh@349 PS5, Line 349: 10 nit: I think this is more of a logical level than number of patches applied. So, this can be 9. -- To view, visit http://gerrit.cloudera.org:8080/23925 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I691d2f442c3148f235847c4c8e56767577804b1a Gerrit-Change-Number: 23925 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Tue, 03 Feb 2026 13:43:17 +0000 Gerrit-HasComments: Yes
