Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23707 )
Change subject: KUDU-1457 [8/n] Parameterize tests with ip config ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/23707/4/src/kudu/util/test_util.cc File src/kudu/util/test_util.cc: http://gerrit.cloudera.org:8080/#/c/23707/4/src/kudu/util/test_util.cc@762 PS4, Line 762: void PrintTo(IPMode mode, std::ostream* os) { : *os << IPModeToString(mode); : } > I'm not sure I understand the concern about 'spreading elsewhere'. Both ve With operator overload approach, I guess I didn't see right file for definition at the time and ended up with multiple definitions in corresponding files wherever used. I didn't want to spend more time on this so I chose PrintTo as it fit the bill. Using test_util.h for operator version should also serve the purpose though. I haven't tried that. -- To view, visit http://gerrit.cloudera.org:8080/23707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic72efea2045b12300ccf0e80873c405828c15a30 Gerrit-Change-Number: 23707 Gerrit-PatchSet: 5 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Tue, 03 Feb 2026 15:50:09 +0000 Gerrit-HasComments: Yes
